From: Marek Vasut Date: Mon, 17 Oct 2011 23:01:50 +0200 Subject: [U-Boot] [PATCH v6 04/20] sandbox: Add compiler defines to support a 64-bit x86_64 platform In-Reply-To: <20111017205912.BBA9B140797D@gemini.denx.de> References: <1318270953-32482-1-git-send-email-sjg@chromium.org> <1318270953-32482-5-git-send-email-sjg@chromium.org> <20111017205912.BBA9B140797D@gemini.denx.de> Message-ID: <201110172301.50564.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, October 17, 2011 10:59:12 PM Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318270953-32482-5-git-send-email-sjg@chromium.org> you wrote: > > This sets __WORDSIZE to 8 correctly on 64-bit machines. > > > > Signed-off-by: Simon Glass > > --- > > Changes in v2: > > - Update commit message to remove 'temporary' > > - Allow __WORDSIZE to be defined in Makefile / elsewhere > > > > include/compiler.h | 12 +++++++++++- > > 1 files changed, 11 insertions(+), 1 deletions(-) > > This commit breaks building of all (or at least almost all, probbaly > all ARM and PPC) boards: > > + ./MAKEALL ppc > In file included from /home/wd/git/u-boot/work/include/image.h:36, > from include/common.h:117: > /home/wd/git/u-boot/work/include/compiler.h:119:2: error: #error > "__SIZEOF_LONG__ has unexpected value" > /home/wd/git/u-boot/work/include/compiler.h:128:2: error: #error > "__WORDSIZE has unexpected value" In file included from > /home/wd/git/u-boot/work/include/image.h:36, from include/common.h:117: > ... > > + ./MAKEALL arm > In file included from /home/wd/git/u-boot/work/include/image.h:36, > from include/common.h:117: > /home/wd/git/u-boot/work/include/compiler.h:119:2: error: #error > "__SIZEOF_LONG__ has unexpected value" > /home/wd/git/u-boot/work/include/compiler.h:128:2: error: #error > "__WORDSIZE has unexpected value" In file included from > /home/wd/git/u-boot/work/include/image.h:36, from include/common.h:117: > ... > > This happend both when building on i686 and on x86_64 build hosts. > > Please fix. > > Best regards, > > Wolfgang Denk Finally, I'm not alone when it comes to breaking all boards ! :-) Simon, next time, try running the MAKEALL to check if nothing is broken :-)