From: Pavel Roskin Date: Tue, 18 Oct 2011 16:19:48 -0400 Subject: [ath9k-devel] [patch] ath9k_hw: min_t() casts u32 to int In-Reply-To: <20111017072823.GA7812@elgon.mountain> References: <20111017072823.GA7812@elgon.mountain> Message-ID: <20111018161948.2552f995@mj> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Mon, 17 Oct 2011 10:28:23 +0300 Dan Carpenter wrote: > The code here treats very large values of "limit" as less than > MAX_POWER_RATE because of the cast to int. We should do the compare > as u32 instead. > > Signed-off-by: Dan Carpenter Reviewed-by: Pavel Roskin I don't think it can actually happen. ath9k_hw_set_txpowerlimit() is called twice. In one case, limit is MAX_RATE_POWER, in another case, it's an argument of type u16. Still, it's better not to have the code that looks wrong. ath9k_cmn_update_txpow() also has code that _looks_ wrong. *txpower is not assigned a value if the new power happens to be equal to the current one. Also, the second argument (cur_txpow) is not used. Returning a value by a pointer seems unnecessary if the function returns void. It could simply return the new tx power. I'll submit a patch shortly. -- Regards, Pavel Roskin