From: Wolfgang Denk Date: Fri, 21 Oct 2011 12:03:21 +0200 Subject: [U-Boot] [PATCH] mii: miiphy register address width change In-Reply-To: References: <1316603432-17780-1-git-send-email-chandan.nath@ti.com> <201110200958.13046.vapier@gentoo.org> <201110201842.19466.vapier@gentoo.org> Message-ID: <20111021100321.34C5C18AE812@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "Kumar Nath, Chandan", In message you wrote: > > > I don't think the patch is correct or incorrect. It attempts to update > > the miiphy_* API to support larger register offsets. I'm suggesting > > that we shouldn't change the legacy API to support new features. > > There's no way to specify via miiphy_write that you want to write to a > > register with a 16-bit register offset, because there's no way to > > specify which device to write. > > > > > So I'm not saying we shouldn't apply this patch. I'm questioning why > > it was written in a hope that we can discourage new use of the old > > API. I'm also not convinced the patch helps anything. > > > > > Andy > > This patch was written to support PHY register whose address width is great> er > than 8 bit. It was not written for 10 gig support. The question remains: Why are you still using the old deprecated legacy API instead of the new one? You will need really good reasons to convince me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Save energy: Drive a smaller shell.