From: Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] VirtioConsole support.
Date: Fri, 28 Oct 2011 18:27:59 +0200
Message-ID: <20111028162759.GA27263@suse.de>
References: <20111027173527.GA23839@phenom.dumpdata.com>
 <1319751802-27013-1-git-send-email-miche@google.com>
 <20111027215535.GA5671@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20111027215535.GA5671@phenom.dumpdata.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Miche Baker-Harvey <miche@google.com>, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, Amit Shah <amit.shah@redhat.com>, Anton Blanchard <anton@samba.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, virtualization@lists.linux-foundation.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Oct 27, 2011 at 05:55:35PM -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 27, 2011 at 02:43:22PM -0700, Miche Baker-Harvey wrote:
> > Multiple HVC console terminals enabled.
> 
> Miche,
> 
> You might want to flesh out the description a bit. Perhaps include
> such details as : "fixes the infinite loop that git commit XX
> caused". Perhaps include some of the serial console output.
> 
> Maybe also change the title - the patch name (which is what shows up
> if you do 'git log --oneline') is 'VirtioConsole support.' which is
> not very informative.

Yes, all of these need to be resolved before I can accept this.

thanks,

greg k-h