From: jesper.nilsson@axis.com (Jesper Nilsson) Date: Tue, 8 Nov 2011 17:34:44 +0100 Subject: [PATCH] RS485: fix inconsistencies in the meaning of some variables In-Reply-To: <4EB94EAA.2010603@evidence.eu.com> References: <4E492CFF.7040905@pwrnet.de> <20110822211832.GA8023@kroah.com> <4EB3A009.10502@evidence.eu.com> <4EB8F6B9.6010008@atmel.com> <4EB90902.4030200@evidence.eu.com> <4EB9447C.4050109@atmel.com> <4EB94EAA.2010603@evidence.eu.com> Message-ID: <20111108163444.GN26898@axis.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 08, 2011 at 04:45:46PM +0100, Claudio Scordino wrote: > Subject: RS485: fix inconsistencies in the meaning of some variables > From: Claudio Scordino > > The crisv10.c and the atmel_serial.c serial drivers intepret the fields of the > serial_rs485 structure in a different way. > In particular, crisv10.c uses SER_RS485_RTS_AFTER_SEND and > SER_RS485_RTS_ON_SEND for the voltage of the RTS pin; atmel_serial.c, instead, > uses these values to know if a delay must be set before and after sending. > This patch makes the usage of these variables consistent across all drivers and > fixes the Documentation as well. > >From now on, SER_RS485_RTS_AFTER_SEND and SER_RS485_RTS_ON_SEND will be used to > set the voltage of the RTS pin (as in the crisv10.c driver); the delay will be > understood by looking only at the value of delay_rts_before_send and > delay_rts_after_send. > > Signed-off-by: Claudio Scordino > Signed-off-by: Darron Black Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson at axis.com