From: Ben Widawsky Subject: Re: [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled Date: Wed, 16 Nov 2011 23:00:42 -0800 Message-ID: <20111116230042.5071006f@bwidawsk.net> References: <1321489075-1322-1-git-send-email-eugeni.dodonov@intel.com> <1321489075-1322-3-git-send-email-eugeni.dodonov@intel.com> <20111117005616.GA27398@bolo_yeung.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CA28A0E1A for ; Wed, 16 Nov 2011 23:01:12 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: keith.packard@intel.com Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Wed, 16 Nov 2011 22:11:06 -0800 keith.packard@intel.com wrote: > On Wed, 16 Nov 2011 16:56:16 -0800, Ben Widawsky wrote: > > > The variable you want is: !intel_iommu_gfx_mapped > > From what Daniel Vetter said: > > > Last time I've played around with all the combinations, only > > intel_iommu=off was good enough to prevent the hang. > > intel_iommu=igd_off still hangs (which is what the current value > > exported by the dmar code dopends on, iirc). If I remember things > > correctly, intel_iommu=off also reliably works around issues for all > > reporters (both semaphores and rc6). > > we need to use dmar_disabled instead of intel_iommu_gfx_mapped. Other > places in the code use: > > if (no_iommu || dmar_disabled) > As long as he meant igfx_off, then okay... igd_off didn't immediately register to me earlier. Sorry for the confusion.