From: Olaf Hering Subject: Re: [PATCH] xen-netfront: report link speed to ethtool Date: Fri, 18 Nov 2011 20:17:22 +0100 Message-ID: <20111118191722.GA16429@aepfle.de> References: <20111118164805.GA14345@aepfle.de> <1321638394.2883.32.camel@bwh-desktop> <20111118184336.GA16027@aepfle.de> <1321643431.2883.39.camel@bwh-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1321643431.2883.39.camel@bwh-desktop> Sender: netdev-owner@vger.kernel.org To: Ben Hutchings Cc: netdev@vger.kernel.org, xen-devel@lists.xensource.com, Jeremy Fitzhardinge , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On Fri, Nov 18, Ben Hutchings wrote: > On Fri, 2011-11-18 at 19:43 +0100, Olaf Hering wrote: > > On Fri, Nov 18, Ben Hutchings wrote: > > > > > On Fri, 2011-11-18 at 17:48 +0100, Olaf Hering wrote: > > > > The reported data refers to VMWare vmxnet. > > > NAK, we should not just make things up. > > > > So how about removing veth_get_settings, vmxnet3_get_settings, > > tun_get_settings and other functions that escaped my grep? > > If they can't provide meaningful information then maybe they should be > removed. However, that could result in a regression for existing > working configurations. (This isn't the same as the case you're trying > to fix, since those applications have never worked with xen-netfront or > many other drivers that don't implement get_settings.) That may be. How about a new generic ethtool_op_get_settings_veth which returns fake values for all relevant drivers (virtio, xen-netfront, and the ones listed above)? Olaf