From: John W. Linville Date: Mon, 21 Nov 2011 14:34:22 -0500 Subject: [ath9k-devel] [PATCH v2] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state. In-Reply-To: <1321767035-3263-1-git-send-email-mar.kolya@gmail.com> References: <1321767035-3263-1-git-send-email-mar.kolya@gmail.com> Message-ID: <20111121193422.GD7153@tuxdriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Sun, Nov 20, 2011 at 12:30:35AM -0500, Nikolay Martynov wrote: > From: kolya > > When tx agg is being stopped TID is flushed using ath_tx_flush_tid. It is possible that ath_tx_flush_tid completelly flushes TID (if all packets in this TID have already been retried). If this happened ath_tx_aggr_stop would leave TID in cleanup state permanently. Fix this by making ath_tx_flush_tid remove AGGR_ADDBA_COMPLETE and AGGR_CLEANUP flags from TID status if TID is empty. Please follow the suggestions Kalle made about your patch. Please also include a Signed-off-by line. John -- John W. Linville Someday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.