From: Jesse Barnes Subject: Re: [PATCH] intel: Update for new i915_drm.h defines. Date: Wed, 4 Jan 2012 08:52:34 -0800 Message-ID: <20120104085234.3ee51fc7@jbarnes-desktop> References: <1325646600-6366-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0075371896==" Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id 095639ED24 for ; Wed, 4 Jan 2012 08:52:40 -0800 (PST) In-Reply-To: <1325646600-6366-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0075371896== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/p+Hfaxl.aZruroyfJxUUKyN"; protocol="application/pgp-signature" --Sig_/p+Hfaxl.aZruroyfJxUUKyN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 3 Jan 2012 19:10:00 -0800 Eric Anholt wrote: > --- >=20 > This syncs the code up to the kernel as of the gen7 SOL changes. It > would be nice if doing this was just a straight copy of the kernel > code -- there are two diffs left out. One is this hunk: >=20 > -#ifdef __KERNEL__ > -/* For use by IPS driver */ > -extern unsigned long i915_read_mch_val(void); > -extern bool i915_gpu_raise(void); > -extern bool i915_gpu_lower(void); > -extern bool i915_gpu_busy(void); > -extern bool i915_gpu_turbo_disable(void); > -#endif >=20 > Does anyone see any real reason to be dropping this? >=20 > The other is removing the sparse __user annotations on the structs. > Could we just patch the kernel to #define it away for userland, so we > could make updating this file just a matter of "cp"? Having just done this locally, I'm in favor. The stuff under __KERNEL__ should be harmless; don't see why we can't just copy it. For the __user define, we must be missing a compiler.h include somewhere in the libdrm case. If you explicitly include it do the errors go away? --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/p+Hfaxl.aZruroyfJxUUKyN Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPBIPSAAoJEIEoDkX4Qk9h9aIP/ApXHdHI5+oNqH1IJpQpq48J ngHezH983udfgAT+SfURXHXSeLkYAjqSgkJNompfB7uWU1qt7MxI0ln7uoz3voXl ZXPBebny+6qoAK+JguISDrH0Kq+pgcYhNN5qFMMiy3JwcVtqt5XceIkNV0pfuSVn g4zLF5lxUayCmLotw98qJ990F/gjghLbNWM95yxKz+ki5hJzB2miEw5sLJ2eBbTb mhm9tI1JoBHf7BhL+4zQVstNCIg+eQEsB3LuDkS1LR5xfmrz6yEy3YHV1kERBui5 GdjtF3B8yJlmPjXsi/d6LXDj0aOyJfP9P6Tyc87vhR7UrUzTAzStw9rPLRoOUedt mE+Ghyx1n1n3eKq6Fd7sKeYOl1eF2ws3srT4H+nz/kmnq/AXse71iZPAONKkqIgw +XJifj4v/zGQ2tTTFAwbV4USez5gIxR3Eb3LAaDlCSgnxaceHeENpsb3+GrrbADf ugbO7LfeZKFIawtBqOZVWM1k02qbsYtIl6qiO8TSlRqizda/fixL8cqiOhKiarZn lABfbvcozSSC9j4/t8G81NV4vreAIgriXphILCuIZLi9e7/a5iYbFxcPLdnOjdbL IysV88DHcsiFdG1TafaiPTdczESQPio8LZYiZrjXXlQGgm0aoQ7IQp0TLDe/TQKI TEQmTjomjilL9e9WWvYi =SkwJ -----END PGP SIGNATURE----- --Sig_/p+Hfaxl.aZruroyfJxUUKyN-- --===============0075371896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0075371896==--