From: Daniel Vetter Subject: Re: [PATCH] intel: Update for new i915_drm.h defines. Date: Wed, 4 Jan 2012 10:34:06 +0100 Message-ID: <20120104093406.GB3833@phenom.ffwll.local> References: <1325646600-6366-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FD219E8FB for ; Wed, 4 Jan 2012 01:32:07 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so25589731wgb.0 for ; Wed, 04 Jan 2012 01:32:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <1325646600-6366-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 03, 2012 at 07:10:00PM -0800, Eric Anholt wrote: > --- > > This syncs the code up to the kernel as of the gen7 SOL changes. It > would be nice if doing this was just a straight copy of the kernel > code -- there are two diffs left out. One is this hunk: > > -#ifdef __KERNEL__ > -/* For use by IPS driver */ > -extern unsigned long i915_read_mch_val(void); > -extern bool i915_gpu_raise(void); > -extern bool i915_gpu_lower(void); > -extern bool i915_gpu_busy(void); > -extern bool i915_gpu_turbo_disable(void); > -#endif > > Does anyone see any real reason to be dropping this? > > The other is removing the sparse __user annotations on the structs. > Could we just patch the kernel to #define it away for userland, so we > could make updating this file just a matter of "cp"? $ make headers_install in the kernel tree should do all this preprocessing for you and drop a sanitized header into usr/include/drm/i915_drm.h. Lazy me hasn't checked whether that would match up perfectly with what's in libdrm though ... -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48