From: Jesse Barnes Subject: Re: [PATCH] intel: Update for new i915_drm.h defines. Date: Wed, 4 Jan 2012 14:57:05 -0800 Message-ID: <20120104145705.12248655@jbarnes-desktop> References: <1325646600-6366-1-git-send-email-eric@anholt.net> <20120104085234.3ee51fc7@jbarnes-desktop> <87r4zfcce2.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1356158663==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 129549F5F1 for ; Wed, 4 Jan 2012 14:57:10 -0800 (PST) In-Reply-To: <87r4zfcce2.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1356158663== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Q+cE77Qb14SLiuEYf=hqNG5"; protocol="application/pgp-signature" --Sig_/Q+cE77Qb14SLiuEYf=hqNG5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 04 Jan 2012 14:48:37 -0800 Eric Anholt wrote: > On Wed, 4 Jan 2012 08:52:34 -0800, Jesse Barnes wrote: > > On Tue, 3 Jan 2012 19:10:00 -0800 > > Eric Anholt wrote: > >=20 > > > --- > > >=20 > > > This syncs the code up to the kernel as of the gen7 SOL changes. It > > > would be nice if doing this was just a straight copy of the kernel > > > code -- there are two diffs left out. One is this hunk: > > >=20 > > > -#ifdef __KERNEL__ > > > -/* For use by IPS driver */ > > > -extern unsigned long i915_read_mch_val(void); > > > -extern bool i915_gpu_raise(void); > > > -extern bool i915_gpu_lower(void); > > > -extern bool i915_gpu_busy(void); > > > -extern bool i915_gpu_turbo_disable(void); > > > -#endif > > >=20 > > > Does anyone see any real reason to be dropping this? > > >=20 > > > The other is removing the sparse __user annotations on the structs. > > > Could we just patch the kernel to #define it away for userland, so we > > > could make updating this file just a matter of "cp"? > >=20 > > Having just done this locally, I'm in favor. The stuff under > > __KERNEL__ should be harmless; don't see why we can't just copy it. > >=20 > > For the __user define, we must be missing a compiler.h include > > somewhere in the libdrm case. If you explicitly include it do the > > errors go away? >=20 > What version of POSIX is compiler.h part of? Remember that this is > userland code built across OSes (as much as we try to forget that). It's one of the Linux kernel headers. I'm such a Linux-ist I didn't even consider an OS that might not have it. We can just #define away __user in drm.h or something to avoid adding OS deps. Or use the header install target like Daniel said and copy from that. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/Q+cE77Qb14SLiuEYf=hqNG5 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPBNlBAAoJEIEoDkX4Qk9h30sP/j8rb727v0mA9sGgJERwAk/f 3yxRgHTMOLRGyWNGEzKEQSw8TZ1Vq1YnhBbO0pZZ3J4WjEhVfX6/zFMwul7uFTio aNcYwZeUZVwfarHlTfWnPhBeRX2DDdkwncIAtd5fGuMcOx0USBPxnc5uKAnsHsUt 7Zb3NaYMmCVjE6tjtitI71BfxJMWn/mSZM3aEr8BMx3GE23IW4EKiRcAVPlRgdRM 76vk6OcslKSOdXzk0qTeWEpOA/Ir84qevXV/9M+EIkycIjFQzUfENQH/qbF3GOcF dZRJsrhb8thf8fAcRHvOWEt8ulaaOcOWWHRrj6MgEPaD7+aDdFqMrFXcJyJyWYTL uBFkHCBfCeYU8qeeCry4UjGqWjaIEyLwnCCFCtiFGJPXNNqC7F32RS+hTPEuLigs zUgDr4KSlLiOeFAwEx01DlSRaYNDirPXr/6S4LEDyIhDYSxCw3e8kmiSfaIGxdPg ihHbNVveBG9HH51PDJUgJF4zKbVm52i3tJ3pWFBQRL3Nu3kkHl4G5aQNWI899CPj pVJsyN8tPasHfXZxzTpVqTuOhXrQ/gEc+YgNy3s1W7asHLHn+RHBzZPBuajQmINI SP4ovmXXyWfYIPoDDL42O2/nI/GRTXDmu9u9gpK1Zb3fW2vrp7gdERBSGI43ebm7 8G39YphmpeHTEWGHsGCH =ExsS -----END PGP SIGNATURE----- --Sig_/Q+cE77Qb14SLiuEYf=hqNG5-- --===============1356158663== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1356158663==--