From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Wed, 11 Jan 2012 17:40:48 +0000 Subject: [PATCH] video: s3c-fb: Add device tree support In-Reply-To: References: <1326139307-25112-1-git-send-email-thomas.abraham@linaro.org> <20120110045219.GA5433@sirena.org.uk> Message-ID: <20120111174048.GC24213@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote: > On 10 January 2012 10:22, Mark Brown > > This isn't terribly informative for the user - which GPIOs and in what > > order are they specified? ?Looking at the code it looks like pin mux > > configuration so just some wording saying it's a list of pins to be used > > for the framebuffer function. > Ok. I will modify the sentence to mean that it is list of gpios used > by framebuffer controller for data/timing interface with the lcd > panel. Thanks for your review. You probably want to mention that it's for pin muxing, the reason I didn't get what it meant on first read was that normally GPIO means specifically the sort of stuff handled by gpiolib.