From: Julien Cristau Subject: Re: [PATCH] drm/i915/dp: Add branch/sink OUI debugging Date: Sat, 14 Jan 2012 11:47:24 +0100 Message-ID: <20120114104724.GY9839@radis.cristau.org> References: <1326479168-17162-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from coloquinte.cristau.org (coloquinte.cristau.org [91.121.16.100]) by gabe.freedesktop.org (Postfix) with ESMTP id AD9C69E732 for ; Sat, 14 Jan 2012 02:47:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <1326479168-17162-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 13, 2012 at 13:26:08 -0500, Adam Jackson wrote: > DisplayPort lets you discover the manufacturer OUI of the other end. > This is good, because it means you might be able to have per-phy quirks > to work around other people's bugs, but it's bad because it removes some > incentive to not make buggy hardware. > > At any rate DisplayPort is proving fickle enough that I'm getting > desperate. Dump the OUI in the log when KMS debug is on. > > Signed-off-by: Adam Jackson > --- > drivers/gpu/drm/i915/intel_dp.c | 33 +++++++++++++++++++++++++++++++++ > include/drm/drm_dp_helper.h | 8 ++++++++ > 2 files changed, 41 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index db3b461..96b3fe2 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2097,6 +2097,37 @@ intel_dp_get_edid_modes(struct drm_connector *connector, struct i2c_adapter *ada > return ret; > } > > +static void > +intel_dp_debug_oui(struct intel_dp *dp, uint8_t dpcd[DP_RECEIVER_CAP_SIZE]) > +{ > + uint8_t count; > + int offset; > + uint8_t oui[3]; > + > + /* not valid in 1.0 */ > + if (dpcd[0] == < 0x11) ^^^^ That looks broken. Cheers, Julien