From: Zeng Zhaoming Subject: Re: [PATCH 1/2] ASoC: sgtl5000: Fix wrong register name in restore Date: Mon, 16 Jan 2012 16:55:05 +0800 Message-ID: <20120116085505.GA15553@zzm-ubuntu> References: <1326698152-25747-1-git-send-email-zengzm.kernel@gmail.com> <7FE21149F4667147B645348EC60578850910FD@039-SN2MPN1-013.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-iy0-f179.google.com (mail-iy0-f179.google.com [209.85.210.179]) by alsa0.perex.cz (Postfix) with ESMTP id EE63124573 for ; Mon, 16 Jan 2012 09:55:18 +0100 (CET) Received: by iakk32 with SMTP id k32so2589786iak.38 for ; Mon, 16 Jan 2012 00:55:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <7FE21149F4667147B645348EC60578850910FD@039-SN2MPN1-013.039d.mgd.msft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Dong Aisheng-B29396 Cc: "alsa-devel@alsa-project.org" , "broonie@opensource.wolfsonmicro.com" , "w.sang@pengutronix.de" , "julia.lawall@lip6.fr" , "shawn.guo@linaro.org" , "festevam@gmail.com" , "lrg@ti.com" List-Id: alsa-devel@alsa-project.org On Mon 2012-01-16 08:35:46, Dong Aisheng-B29396 wrote: > > -----Original Message----- > > From: zengzm.kernel@gmail.com [mailto:zengzm.kernel@gmail.com] > > Sent: Monday, January 16, 2012 3:16 PM > > To: alsa-devel@alsa-project.org > > Cc: Dong Aisheng-B29396; broonie@opensource.wolfsonmicro.com; > > julia.lawall@lip6.fr; festevam@gmail.com; w.sang@pengutronix.de; > > shawn.guo@linaro.org; lrg@ti.com; zengzm.kernel@gmail.com > > Subject: [PATCH 1/2] ASoC: sgtl5000: Fix wrong register name in restore > > Importance: High > > > > From: Zeng Zhaoming > > > > Correct SGTL5000_CHIP_CLK_CTRL to SGTL5000_CHIP_REF_CTRL in > > sgtl5000_restore_regs(), and add comment to explain the restore order. > > > The change is ok to me. > One minor thing: > > > Signed-off-by: Zeng Zhaoming > > --- > > sound/soc/codecs/sgtl5000.c | 11 +++++++++-- > > 1 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index > > fc9b127..71df1fe 100644 > > --- a/sound/soc/codecs/sgtl5000.c > > +++ b/sound/soc/codecs/sgtl5000.c > > @@ -987,12 +987,12 @@ static int sgtl5000_restore_regs(struct snd_soc_codec > > *codec) > > /* restore regular registers */ > > for (reg = 0; reg <= SGTL5000_CHIP_SHORT_CTRL; reg += 2) { > > > > - /* this regs depends on the others */ > > + /* These regs should restore in particular order */ > > if (reg == SGTL5000_CHIP_ANA_POWER || > > reg == SGTL5000_CHIP_CLK_CTRL || > > reg == SGTL5000_CHIP_LINREG_CTRL || > > reg == SGTL5000_CHIP_LINE_OUT_CTRL || > > - reg == SGTL5000_CHIP_CLK_CTRL) > > + reg == SGTL5000_CHIP_REF_CTRL) > > continue; > > > > snd_soc_write(codec, reg, cache[reg]); @@ -1005,6 +1005,13 @@ > > static int sgtl5000_restore_regs(struct snd_soc_codec *codec) > > /* > > * restore power and other regs according > > * to set_power() and set_clock() > There's no such functions in this driver. > Can we change the comment to something like: > "restore power and other regs according to the power and clock setting sequence". > That's easier to understand. Thanks, you will see this next. > > > + * the order of restore is: > > + * 1. SGTL5000_CHIP_CLK_CTRL MCLK_FREQ bits (1:0) should be restore after > > + * SGTL5000_CHIP_ANA_POWER PLL bits set > > + * 2. SGTL5000_CHIP_LINREG_CTRL should be set before > > + * SGTL5000_CHIP_ANA_POWER LINREG_D restored > > + * 3. SGTL5000_CHIP_REF_CTRL controls Analog Ground Voltage, > > + * I prefer to resotre it after SGTL5000_CHIP_ANA_POWER restored > > */ > > snd_soc_write(codec, SGTL5000_CHIP_LINREG_CTRL, > > cache[SGTL5000_CHIP_LINREG_CTRL]); > > -- > > 1.7.6.1.385.gb7fcd0 > > > > Regards > Dong Aisheng