From: Daniel Vetter Subject: Re: [PATCH] drm/i915/sdvo: Enforce more timing requirements Date: Mon, 16 Jan 2012 23:02:29 +0100 Message-ID: <20120116220229.GQ3627@phenom.ffwll.local> References: <87hb1aodlt.fsf@eliezer.anholt.net> <1323789390-18078-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D90159E734 for ; Mon, 16 Jan 2012 14:02:33 -0800 (PST) Received: by werm13 with SMTP id m13so1531159wer.36 for ; Mon, 16 Jan 2012 14:02:33 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 13, 2011 at 02:09:28PM -0200, Paulo Zanoni wrote: > Hi > = > 2011/12/13 Adam Jackson : > > + =A0 =A0 =A0 if (mode->vtotal - mode->vdisplay < 3) > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return MODE_VBLANK_NARROW; > > + > > + =A0 =A0 =A0 if (mode->vsync_end - mode->vsync_start < 1) > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return MODE_VSYNC_NARROW; > > + > > + =A0 =A0 =A0 if (mode->htotal - mode->hdisplay < 16) > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return MODE_HBLANK_NARROW; > > + > > + =A0 =A0 =A0 if (mode->hsync_end - mode->hsync_start < 16) > = > I believe in this line above it should be 2 instead of 16. > = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return MODE_HSYNC_NARROW; > > + > > =A0 =A0 =A0 =A0return MODE_OK; > > =A0} Anything up with this patch or is this one for the bitbucket in the binary heavens? -Daniel -- = Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48