From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Probe SDVO LVDS information Date: Mon, 16 Jan 2012 23:19:52 +0100 Message-ID: <20120116221952.GR3627@phenom.ffwll.local> References: <1322505131-6427-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 0203D9E734 for ; Mon, 16 Jan 2012 14:19:56 -0800 (PST) Received: by wgbdr11 with SMTP id dr11so1971877wgb.12 for ; Mon, 16 Jan 2012 14:19:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <1322505131-6427-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Nov 28, 2011 at 01:32:11PM -0500, Adam Jackson wrote: > No effect besides printing the result in dmesg if debugging is enabled. > > Signed-off-by: Adam Jackson This looks strange without dmesg output nor a comment added. Quick survey on irc with Jesse and Chris showed that we want interesting stuff decoded into dmesg or debugfs ... hint ;-) -Daniel > --- > drivers/gpu/drm/i915/intel_sdvo.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index 3003fb2..c3810d2 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -2113,6 +2113,15 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) > return true; > } > > +static void > +intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo) > +{ > + u8 info; > + intel_sdvo_get_value(intel_sdvo, > + SDVO_CMD_GET_LVDS_PANEL_INFORMATION, > + &info, sizeof(info)); > +} > + > static bool > intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device) > { > @@ -2145,6 +2154,8 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device) > if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector)) > goto err; > > + intel_sdvo_lvds_probe_panel_information(intel_sdvo); > + > return true; > > err: > -- > 1.7.6.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48