From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/i915/dp: Tweak auxch clock divider for PCH Date: Tue, 17 Jan 2012 16:49:33 +0100 Message-ID: <20120117154933.GN4093@phenom.ffwll.local> References: <1311709186-13027-1-git-send-email-ajax@redhat.com> <20120117071935.237264d6@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id C05459E926 for ; Tue, 17 Jan 2012 07:49:37 -0800 (PST) Received: by werm13 with SMTP id m13so2251873wer.36 for ; Tue, 17 Jan 2012 07:49:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20120117071935.237264d6@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 17, 2012 at 07:19:35AM -0800, Jesse Barnes wrote: > On Tue, 26 Jul 2011 15:39:44 -0400 > Adam Jackson wrote: > > > Matches the advice in the Sandybridge documentation. > > > > Signed-off-by: Adam Jackson > > --- > > drivers/gpu/drm/i915/intel_dp.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > index dcc7ae6..3ad90f6 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -305,7 +305,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > > else > > aux_clock_divider = 225; /* eDP input clock at 450Mhz */ > > } else if (HAS_PCH_SPLIT(dev)) > > - aux_clock_divider = 62; /* IRL input clock fixed at 125Mhz */ > > + aux_clock_divider = 63; /* IRL input clock fixed at 125Mhz */ > > else > > aux_clock_divider = intel_hrawclk(dev) / 2; > > I have no problem with this set; matching the docs is nice. However > we'll need to get some good test coverage before I feel comfortable. Ok, Jesse upped these noises of approval into acked-bys on irc. Queued all 3 patches for -next. Thanks, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48