From: Mike Frysinger Date: Tue, 24 Jan 2012 16:45:11 -0500 Subject: [U-Boot] [PATCH v3 7/8] sandbox: Add flags for open() call In-Reply-To: <1327301333-30776-7-git-send-email-sjg@chromium.org> References: <1327301333-30776-1-git-send-email-sjg@chromium.org> <1327301333-30776-7-git-send-email-sjg@chromium.org> Message-ID: <201201241645.12414.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 23 January 2012 01:48:52 Simon Glass wrote: > This provides a way for callers to create files for writing. We define > flags which mirror the POSIX values. there are no POSIX values, just names. the way the defines get interpreted is left up to implementations. > @@ -19,11 +24,7 @@ > * MA 02111-1307 USA > */ > > -/* > - * Operating System Interface > - * > - * This provides access to useful OS routines from the sandbox > architecture - */ > +struct sandbox_state; looks like unrelated stuff got squished into here > +#define OS_O_RDONLY 0 > +#define OS_O_WRONLY 1 > +#define OS_O_RDWR 2 > +#define OS_O_CREAT 0100 seems to be whitespace mismatch between "#define" and the actual define. some use tabs and some spaces ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: