From: Mike Frysinger Date: Fri, 3 Feb 2012 14:31:47 -0500 Subject: [U-Boot] [PATCH v8 4/4] EXYNOS: SMDK5250: Add MMC SPL support In-Reply-To: <1328285157-23780-5-git-send-email-chander.kashyap@linaro.org> References: <1328285157-23780-1-git-send-email-chander.kashyap@linaro.org> <1328285157-23780-5-git-send-email-chander.kashyap@linaro.org> Message-ID: <201202031431.50572.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 03 February 2012 11:05:57 Chander Kashyap wrote: > board/samsung/smdk5250/tools/mkexynos_image.c | 117 > create mode 100644 tools/mksmdk5250spl.c something funky in your diffstat ... says you're creating tools/ but the diffstat shows board/.../tools/. but the diff below looks correct. > --- /dev/null > +++ b/tools/mksmdk5250spl.c you could still name it "mkexynos_image". up to you. > + if (fstat(ifd, &stat)) { > + close(ifd); > + close(ofd); > + } looks like you should issue a warning + exit here -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: