From: Wolfgang Denk Date: Fri, 30 Mar 2012 22:29:36 +0200 Subject: [U-Boot] [PATCH] command, log: print with "log show" a full logbuffer In-Reply-To: <1329390141-5356-1-git-send-email-hs@denx.de> References: <1329390141-5356-1-git-send-email-hs@denx.de> Message-ID: <20120330202936.94038202B2B@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko Schocher, In message <1329390141-5356-1-git-send-email-hs@denx.de> you wrote: > If the logbuffer contains LOGBUFF_LEN chars, they never got > printed with the "log show" command, because chars get > printed with the following for loop: > > for (i = 0; i < (size & LOGBUFF_MASK); i++) { > > with size = LOGBUFF_LEN and LOGBUFF_MASK = (LOGBUFF_LEN-1) > for loop never executed ... > > Fix this. > > Signed-off-by: Heiko Schocher > --- > common/cmd_log.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "This is a test of the Emergency Broadcast System. If this had been an actual emergency, do you really think we'd stick around to tell you?"