From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] qemu/configure: fix CFLAGS handling for
	i386
Date: Sat, 31 Mar 2012 18:55:24 +0200
Message-ID: <20120331165524.GA26203@aepfle.de>
References: <20120330152436.GA31016@aepfle.de> <4F772590.2000603@suse.de>
	<CAFEAcA9HOS75B_SdocuWENaKtgghDVrXNAZDVTJJf7Vs_AB+1Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <CAFEAcA9HOS75B_SdocuWENaKtgghDVrXNAZDVTJJf7Vs_AB+1Q@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: Peter Maydell <peter.maydell@linaro.org>
Cc: xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org

On Sat, Mar 31, Peter Maydell wrote:

> On 31 March 2012 16:41, Andreas Färber <afaerber@suse.de> wrote:
> > This is the only usage of += outside Makefile fragments, so I wonder if
> > its use may have been by accident. Is it safe in a POSIX context?
> > Or should we better use CFLAGS="$CFLAGS -march=486"?
> > For QEMU_CFLAGS we use the pattern QEMU_CFLAGS="-options $QEMU_CFLAGS"
> > to allow overriding options.
> 
> For that matter, should this be setting QEMU_CFLAGS instead of
> CFLAGS? I have to say I'm not entirely sure what the difference
> is...

I havent looked into qemu build internals, but there is most likely a
concept of HOST_TOOLS_CFLAGS and TARGET_CFLAGS in qemus Makefiles.

Olaf