Return-Path: Date: Mon, 9 Apr 2012 21:03:23 +0200 From: Oleg Nesterov To: David Howells , Linus Torvalds Cc: Andrew Morton , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 0/1] cred: copy_process() should clear child->replacement_session_keyring Message-ID: <20120409190323.GA14712@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: Hello. Looks trivial, but I do not know how to test and I don't understand this code. David, please review ;) Note: initially this was 1/2. The usage of >replacement_session_keyring is racy, although the problem is minor. I think that instead of fixing a lot of key_replace_session_keyring's callers in arch/ we can add the simple abstraction layer and kill ->replacement_session_keyring. I'll try to send the patches tomorrow. Btw. exit_creds() does validate_creds(cred) right before put_cred(cred), without alter_cred_subscribers() in between this looks unneeded? Oleg.