From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/i915: i915_gem_object_sync must handle NULL Date: Wed, 11 Apr 2012 21:01:22 +0200 Message-ID: <20120411190122.GQ4296@phenom.ffwll.local> References: <1334168301-4699-1-git-send-email-ben@bwidawsk.net> <1334169670_371200@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 54E6B9F676 for ; Wed, 11 Apr 2012 12:00:30 -0700 (PDT) Received: by werp11 with SMTP id p11so929861wer.36 for ; Wed, 11 Apr 2012 12:00:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334169670_371200@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 11, 2012 at 07:41:04PM +0100, Chris Wilson wrote: > On Wed, 11 Apr 2012 11:18:19 -0700, Ben Widawsky wrote: > > When I extracted the synchronization code for implementing semaphorified > > pageflips (74f5f6e0), I neglected the non pipelined case which also > > calls this code. The modesetting code wants to make sure the object has > > finished rendering to the frame before configuring the scanout (ie. > > non-pipelined case). > > > > As a result of a follow on discussion on IRC, I've decided to add a > > comment about the function itself which received much inspiration from > > Chris as well. So really, this patch was ghost-written by Chris :). > > > > Reported-by: Chris Wilson > > Signed-off-by: Ben Widawsky > Reviewed-by: Chris Wilson > Tested-by: Chris Wilson I've picked up all 3 patches for -next, thanks for them. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48