From: Jan Kara Subject: Re: [PATCH 4/7] writeback: Separate inode requeueing after writeback Date: Mon, 30 Apr 2012 23:42:37 +0200 Message-ID: <20120430214237.GC10105@quack.suse.cz> References: <1332284191-21076-1-git-send-email-jack@suse.cz> <1332284191-21076-5-git-send-email-jack@suse.cz> <20120430144340.GE10964@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Wu Fengguang , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:35702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756635Ab2D3Vmi (ORCPT ); Mon, 30 Apr 2012 17:42:38 -0400 Content-Disposition: inline In-Reply-To: <20120430144340.GE10964@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 30-04-12 10:43:40, Christoph Hellwig wrote: > > +static void inode_wb_requeue(struct inode *inode, struct bdi_writeback *wb, > > + struct writeback_control *wbc) > > I'd just call this requeue_inode to fit the naming scheme in elsewhere > in the file. I'd also suggest adding a small top of function comment > explaining it. > > Otherwise looks good, > > Reviewed-by: Christoph Hellwig OK, comment added: /* * Find proper writeback list for the inode depending on its current state and * possibly also change of its state while we were doing writeback. Here we * handle things such as livelock prevention or fairness of writeback among * inodes. This function can be called only by flusher thread - noone else * processes all inodes in writeback lists and requeueing inodes behind flusher * thread's back can have unexpected consequences. */ Honza -- Jan Kara SUSE Labs, CR