From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v3 1/6] memcg: fix error code in
 hugetlb_force_memcg_empty()
Date: Mon, 14 May 2012 11:32:19 -0700
Message-ID: <20120514183219.GG2366@google.com>
References: <4FACDED0.3020400@jp.fujitsu.com>
 <4FACDFAE.5050808@jp.fujitsu.com>
 <20120514181556.GE2366@google.com>
Mime-Version: 1.0
Return-path: <cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        bh=Nq6l2ygQ2DU1Xw7961ck9f7L9wO36D67eZXOqdRA46c=;
        b=Wye/xdOWePWZRsGoHqC5PnaXuFsAkqE9/t1SK+YXKVWWGs8wrLzwEWzotO0ttbO4P0
         DBgfXoYeBjTW753Miewota02eZuRx8M4emvCN55T0pNDb0WqwFAQZgevFomO9I+ltLFE
         M7zzmSdE8LRf5/8BXesl+0KipglFkhMvcqn368AC171NnSXxcPAU0cV24untA5i6SdTX
         OhQ+XtB0S44EkCZ8GPWVWCyRtQnQFfXFngxqZctFEtmcQtxaJfjyOjjaAbCsKbkL1dn3
         Ek0dUbYXzg/fHuQDquG/SXScBR9hETBL1WDNzPoFGkVTwhBbu3epUBe7DzTuMi/xjRq2
         1ZlQ==
Content-Disposition: inline
In-Reply-To: <20120514181556.GE2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-ID: <cgroups.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Han Ying <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>, "Aneesh Kumar K.V" <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Hiroyuki Kamezawa <kamezawa.hiroyuki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Linux Kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>

On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote:
> On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote:
> > -		if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children))
> > +		if (cgroup_task_count(cgroup)
> > +			|| !list_empty(&cgroup->children)) {
> > +			ret = -EBUSY;
> >  			goto out;
> 
> Why break the line?  It doesn't go over 80 col.

Ooh, it does.  Sorry, my bad.  But still, isn't it more usual to leave
the operator in the preceding line and align the start of the second
line with the first?  ie.

		if (cgroup_task_count(cgroup) ||
		    !list_empty(&cgroup->children)) {

Thanks.

-- 
tejun