From: Paul Mundt <lethal@linux-sh.org>
Date: Thu, 17 May 2012 07:24:50 +0000
Subject: Re: [PATCH][RESEND] gpio: Emma Mobile GPIO driver V2
Message-Id: <20120517072450.GC11623@linux-sh.org>
List-Id: <linux-sh.vger.kernel.org>
References: <20120517062223.1314.98945.sendpatchset@w520>
In-Reply-To: <20120517062223.1314.98945.sendpatchset@w520>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, rjw@sisk.pl, linus.walleij@stericsson.com, arnd@arndb.de, linux-sh@vger.kernel.org, horms@verge.net.au, grant.likely@secretlab.ca, olof@lixom.net

On Thu, May 17, 2012 at 03:22:23PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> This patch is V2 of the Emma Mobile GPIO driver. This
> driver is designed to be reusable between multiple SoCs
> that share the same basic building block, but so far it
> has only been used on Emma Mobile EV2.
> 
> Each driver instance handles 32 GPIOs with individually
> maskable IRQs. The driver operates on two I/O memory 
> ranges and the 32 GPIOs are hooked up to two interrupts.
> 
> In the case of Emma Mobile EV2 this GPIO building block
> is used as main external interrupt controller hooking up
> 159 GPIOS as 159 interrupts via 5 driver instances and
> 10 interrupts to the GIC and the Cortex-A9 Dual.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> 
>  Rafael, can you please pick up?
> 
>  Changes since V1:
>  - use inline for private data functions using container_of() 
>  - use BIT(n) instead of 1 << n
>  - added legacy irq domain support for static mappings

My distaste for arbitrary static mappings aside, it makes no sense to
support this as a module if the irq domain can't be cleaned up at
present.