From: Borislav Petkov Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Date: Wed, 30 May 2012 19:32:48 +0200 Message-ID: <20120530173247.GC15635@x1.osrc.amd.com> References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <4FC63DAF0200007800086DC5@nat28.tlf.novell.com> <4FC62888.9010407@amd.com> <20120530144851.GA12184@jshin-Toonie> <20120530145005.GI3207@phenom.dumpdata.com> <20120530150334.GA13349@jshin-Toonie> <20120530171754.GA5115@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20120530171754.GA5115@phenom.dumpdata.com> Sender: linux-kernel-owner@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: Jacob Shin , Andre Przywara , jeremy@goop.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Jan Beulich , hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org On Wed, May 30, 2012 at 01:17:54PM -0400, Konrad Rzeszutek Wilk wrote: > > Yes, the following patch also fixed the crash for us: > > > > Implement rdmsr_regs and wrmsr_regs for Xen pvops. > > That needs more data. Such as the reason for it, the crash > tombstone, and an analysis of the bug. > > But at this point I am not sure what we are going to do. > > I think Peter leans towards ripping the .rdmsr_regs/wdmsr_regs > function out altogether (so altering the amd_rdmsr... to use the > .rdmsr/.wrdmsr). At which point I think this would all work > just fine? I wouldn't do that. Andre's patch switches to the rdmsrl_safe/checking_wrmsrl functions so you don't need to implement the _regs functions for pvops. I'll send it now with corrected commit message. > I am tempted to write a patch that checks all the pv-cpu-ops to see if > there are any that are NULL and throw a warning so that this does not > hit us in the future - to be at least more proactive about this sort > of thing. This could be a prudent thing to do. -- Regards/Gruss, Boris.