From: Al Viro Subject: Re: [PATCH 1/2] Revert "[PATCH] vfs: switch ->show_devname() to struct dentry *" Date: Thu, 31 May 2012 15:32:34 +0100 Message-ID: <20120531143234.GD11775@ZenIV.linux.org.uk> References: <4FC74707.5030804@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Fsdevel , Linux Btrfs , Chris Mason To: Miao Xie Return-path: Content-Disposition: inline In-Reply-To: <4FC74707.5030804@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 31, 2012 at 06:25:11PM +0800, Miao Xie wrote: > This reverts commit d861c630e99febe5ce6055290085556c5b714b06 > > It is done to fix the wrong mount information of btrfs in /proc. > Btrfs is an interesting filesystem that can be made by several disks, and > we can remove any disk from the filesystem. But now if we remove the disk > that is specified at mount, the mount information in /proc(such as mounts/ > mountinfo and so on) is not updated. And this wrong information will make > us can not add that special disk back to the filesystem again. I will fix > this problem by implement the show_devname() interface for btrfs, and in > order to check the disk which is specified when doing mount is removed or not, > I want pass vfsmount object into this function. Keep wanting. Patch NAKed.