From: Ingo Molnar Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Date: Wed, 6 Jun 2012 11:27:13 +0200 Message-ID: <20120606092713.GB9495@gmail.com> References: <20120530150334.GA13349@jshin-Toonie> <20120530171754.GA5115@phenom.dumpdata.com> <20120530173247.GC15635@x1.osrc.amd.com> <4FC65D34.1060803@zytor.com> <20120530175150.GE15438@x1.osrc.amd.com> <4FC66037.6020506@zytor.com> <20120530181722.GF15438@x1.osrc.amd.com> <4FC664E1.9050504@zytor.com> <20120530223334.GB28417@andromeda.dapyr.net> <4FC6A897.6020005@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4FC6A897.6020005@zytor.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Peter Anvin" Cc: Konrad Rzeszutek Wilk , Borislav Petkov , Konrad Rzeszutek Wilk , Jacob Shin , Andre Przywara , jeremy@goop.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Jan Beulich , mingo@elte.hu, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org * H. Peter Anvin wrote: > On 05/30/2012 03:33 PM, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > > index 75f33b2..e74df95 100644 > > --- a/arch/x86/xen/enlighten.c > > +++ b/arch/x86/xen/enlighten.c > > @@ -1116,7 +1116,10 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = { > > .wbinvd = native_wbinvd, > > > > .read_msr = native_read_msr_safe, > > + .rdmsr_regs = native_rdmsr_safe_regs, > > .write_msr = xen_write_msr_safe, > > + .wrmsr_regs = native_wrmsr_safe_regs, > > + > > .read_tsc = native_read_tsc, > > .read_pmc = native_read_pmc, > > > > Okay, tell me again: > > why do we have these hooks again? Can we please weed out > paravirt methods that have no users? ping? Ingo