From: tony@atomide.com (Tony Lindgren) Date: Wed, 13 Jun 2012 04:54:45 -0700 Subject: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings In-Reply-To: <20120613113217.GK12766@atomide.com> References: <4FD63DBF.9000200@ti.com> <4FD77E35.3050703@ti.com> <20120613113217.GK12766@atomide.com> Message-ID: <20120613115445.GM12766@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Tony Lindgren [120613 04:36]: > * Mohammed, Afzal [120612 22:00]: > > Hi Jon, > > > > On Tue, Jun 12, 2012 at 23:06:53, Hunter, Jon wrote: > > > > > Should you at least warn, if you are going to over-write a value? > > > > Yes, that would be better except for too much logging, if Tony > > prefers that way I will add. > > If there's a chance it causing file system corruption, we should > test it carefully on the boards before applying. If that's done, > then there's probably no need for warnings. It's safer to disable > NAND for untested boards if there's a chance of breaking the timings. Actually this patch breaks at least DMA on tusb6010 on n8x0. That's a MUSB hardware in a wrapper connected to GPMC that's very picky with the timings. Got any hints what should be done with the cycle2cycle stuff for tusb6010? Tony