From: Wolfgang Denk Date: Sat, 28 Jul 2012 00:14:36 +0200 Subject: [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx In-Reply-To: <201207272326.26896.marex@denx.de> References: <1343419212-18716-1-git-send-email-marex@denx.de> <20120727205644.5DCDC203AC0@gemini.denx.de> <201207272326.26896.marex@denx.de> Message-ID: <20120727221436.97087200166@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek, In message <201207272326.26896.marex@denx.de> you wrote: > > > > - k = (immr << 16) | *((ushort *) & immap->im_cpm.cp_dparam[0xB0]); > > > + k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]); > > > > I think this is wrong. readw() is a little endian I/O accessor, but > > PPC is all big-endian. > > So in_be32 it is, I guess? Wrong again. Looks more like in_be16 to me... > > Guess this was untested? > > Of course it was not. Had trouble even sending this via the crappy cellular> > connection on a train ;-) You tested it? And it worked? I'm surprised. ... Really?? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Worlds are conquered, galaxies destroyed -- but a woman is always a woman. -- Kirk, "Conscience of the King", stardate unknown