From: Daniel Vetter Subject: Re: [PATCH 4/4 v2] drm/i915: Never read FORCEWAKE Date: Mon, 3 Sep 2012 10:30:31 +0200 Message-ID: <20120903083031.GH5225@phenom.ffwll.local> References: <1346565590-1760-1-git-send-email-ben@bwidawsk.net> <1346565590-1760-4-git-send-email-ben@bwidawsk.net> <6c3329$5q3u4c@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 7135E9E738 for ; Mon, 3 Sep 2012 01:30:02 -0700 (PDT) Received: by bkcji2 with SMTP id ji2so2164363bkc.36 for ; Mon, 03 Sep 2012 01:30:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6c3329$5q3u4c@orsmga002.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Sep 02, 2012 at 09:41:44AM +0100, Chris Wilson wrote: > On Sat, 1 Sep 2012 22:59:50 -0700, Ben Widawsky wrote: > > The same designer from the previous patch has told us to never read > > FORCEWAKE. We only do this for the POSTING_READ(), so simply change that > > to something within the same cacheline (for no reason in particular > > other than it sounds nice). In the _mt case we can leverage > > the gtfifodbg check for the POSTING_READ. > > The first two are Reviewed-by: Chris Wilson > The real meat of the change in the second two look good, so > Acked-by: Chris Wilson All slurped into dinq (with some frobbing due to the vlv patches), thanks. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48