From: Ben Widawsky Subject: Re: [PATCH 1/2] drm/i915: s/cacheing/caching/ Date: Tue, 25 Sep 2012 09:55:35 -0700 Message-ID: <20120925095535.7e8b2590@bwidawsk.net> References: <1348272081-5357-1-git-send-email-ben@bwidawsk.net> <051c15$4ds0tq@AZSMGA002.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 10CA1A086E for ; Tue, 25 Sep 2012 09:55:50 -0700 (PDT) In-Reply-To: <051c15$4ds0tq@AZSMGA002.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 25 Sep 2012 10:43:55 +0100 Chris Wilson wrote: > On Tue, 25 Sep 2012 10:32:17 +0200, Daniel Vetter wrote: > > On Sat, Sep 22, 2012 at 2:01 AM, Ben Widawsky wrote: > > > From: Ben Widawsky > > > > > > Signed-off-by: Ben Widawsky > > > > IIrc we're already including this header in shipping libdrm, and we > > have already users for it ... Have you checked whether this doesn't > > break anything once copied over to libdrm? Maybe we just need a few > > #defines for the old names ... > > It doesn't affect the ddx since it is still using its own prototype, and > there has yet to be a patch for Mesa to use this knowledge. > -Chris > Quickly! -- Ben Widawsky, Intel Open Source Technology Center