From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: s/cacheing/caching/ Date: Wed, 26 Sep 2012 13:49:31 +0200 Message-ID: <20120926114931.GB1980@bremse> References: <1348272081-5357-1-git-send-email-ben@bwidawsk.net> <051c15$4ds0tq@AZSMGA002.ch.intel.com> <20120925095535.7e8b2590@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by gabe.freedesktop.org (Postfix) with ESMTP id B127B9E776 for ; Wed, 26 Sep 2012 04:49:37 -0700 (PDT) Received: by lbbgi11 with SMTP id gi11so836222lbb.36 for ; Wed, 26 Sep 2012 04:49:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120925095535.7e8b2590@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 25, 2012 at 09:55:35AM -0700, Ben Widawsky wrote: > On Tue, 25 Sep 2012 10:43:55 +0100 > Chris Wilson wrote: > > > On Tue, 25 Sep 2012 10:32:17 +0200, Daniel Vetter wrote: > > > On Sat, Sep 22, 2012 at 2:01 AM, Ben Widawsky wrote: > > > > From: Ben Widawsky > > > > > > > > Signed-off-by: Ben Widawsky > > > > > > IIrc we're already including this header in shipping libdrm, and we > > > have already users for it ... Have you checked whether this doesn't > > > break anything once copied over to libdrm? Maybe we just need a few > > > #defines for the old names ... > > > > It doesn't affect the ddx since it is still using its own prototype, and > > there has yet to be a patch for Mesa to use this knowledge. > > -Chris > > > > Quickly! Done! I think I'll punt on the hsw pte stuff a bit, prod me on (internal) irc for the reasons ... (and to prove me wrong). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch