From: Ben Widawsky Subject: Re: [PATCH 2/3] drm/i915: Workaround to bump rc6 voltage to 450 Date: Sat, 29 Sep 2012 13:07:35 -0700 Message-ID: <20120929130735.1783a731@bwidawsk.net> References: <1348680842-3036-1-git-send-email-ben@bwidawsk.net> <1348680842-3036-2-git-send-email-ben@bwidawsk.net> <20120927110557.5ff2074b@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FCEA9F6C1 for ; Sat, 29 Sep 2012 13:07:46 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 28 Sep 2012 10:13:26 +1000 Dave Airlie wrote: > On Fri, Sep 28, 2012 at 4:05 AM, Jesse Barnes wrote: > > On Wed, 26 Sep 2012 10:34:01 -0700 > > Ben Widawsky wrote: > > > >> BIOS should be setting the minimum voltage for rc6 to be 450mV. Old or > >> buggy BIOSen may not be doing this, so we correct it for them. Ideally > >> customers should update the BIOS as only it would know the optimal > >> values for the platform, so we leave that fact as a DRM_ERROR for the > >> user to see. > >> > >> Unfortunately this isn't fixing any of the issues it was targeted to > >> fix, but it is documented that we must do it. > > Yeah drop the DRM_ERROR, it should be DRM_INFO at worst, and > non-existant at best. > > Who gives a shit if you have to upgrade your BIOS, lots of vendors > won't provide updates and I don't see Intel doing anything to solve > that. > > Dave. I dunno, messing with voltages seems pretty scary to me. I'd really like a loud warning when the driver does it. I perhaps agree that telling the user to update the BIOS isn't a message we want to classify as an ERROR. I think at least a DRM_DEBUG_DRIVER, but I give Daniel permission to change it as he sees fit assuming the rest of the patch is fine for everyone. -- Ben Widawsky, Intel Open Source Technology Center