From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915: Add rc6vids to debugfs Date: Mon, 15 Oct 2012 21:00:51 +0200 Message-ID: <20121015190051.GB5753@phenom.ffwll.local> References: <1348680842-3036-1-git-send-email-ben@bwidawsk.net> <1348680842-3036-3-git-send-email-ben@bwidawsk.net> <20120927110621.271379b6@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id ED6469E92C for ; Mon, 15 Oct 2012 11:59:50 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id dq11so3817166wgb.12 for ; Mon, 15 Oct 2012 11:59:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120927110621.271379b6@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 27, 2012 at 11:06:21AM -0700, Jesse Barnes wrote: > On Wed, 26 Sep 2012 10:34:02 -0700 > Ben Widawsky wrote: > > > CC: Jesse Barnes > > Signed-off-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index 6647585..3c5710f 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -1069,7 +1069,7 @@ static int gen6_drpc_info(struct seq_file *m) > > struct drm_info_node *node = (struct drm_info_node *) m->private; > > struct drm_device *dev = node->minor->dev; > > struct drm_i915_private *dev_priv = dev->dev_private; > > - u32 rpmodectl1, gt_core_status, rcctl1; > > + u32 rpmodectl1, gt_core_status, rcctl1, rc6vids = 0; > > unsigned forcewake_count; > > int count=0, ret; > > > > @@ -1097,6 +1097,7 @@ static int gen6_drpc_info(struct seq_file *m) > > > > rpmodectl1 = I915_READ(GEN6_RP_CONTROL); > > rcctl1 = I915_READ(GEN6_RC_CONTROL); > > + sandybridge_pcode_read(dev_priv, GEN6_PCODE_READ_RC6VIDS, &rc6vids); > > mutex_unlock(&dev->struct_mutex); > > > > seq_printf(m, "Video Turbo Mode: %s\n", > > @@ -1149,6 +1150,12 @@ static int gen6_drpc_info(struct seq_file *m) > > seq_printf(m, "RC6++ residency since boot: %u\n", > > I915_READ(GEN6_GT_GFX_RC6pp)); > > > > + seq_printf(m, "RC6 voltage: %dmV\n", > > + GEN6_DECODE_RC6_VID(((rc6vids >> 0) & 0xff))); > > + seq_printf(m, "RC6+ voltage: %dmV\n", > > + GEN6_DECODE_RC6_VID(((rc6vids >> 8) & 0xff))); > > + seq_printf(m, "RC6++ voltage: %dmV\n", > > + GEN6_DECODE_RC6_VID(((rc6vids >> 16) & 0xff))); > > return 0; > > } > > > > Nice. > > Reviewed-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch