From: Daniel Vetter Subject: Re: [PATCH] drm/i915: be less verbose about inability to provide vendor backlight Date: Fri, 26 Oct 2012 17:45:43 +0200 Message-ID: <20121026154543.GJ5691@phenom.ffwll.local> References: <1351151859-24853-1-git-send-email-jani.nikula@intel.com> <275ffc$74tp0r@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B2149E7D2 for ; Fri, 26 Oct 2012 08:44:41 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id n13so917210eaa.36 for ; Fri, 26 Oct 2012 08:44:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <275ffc$74tp0r@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Oct 25, 2012 at 09:51:06AM +0100, Chris Wilson wrote: > On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula wrote: > > commit 28dcc2d60cb570d9f549c329b2f51400553412a1 > > Author: Jani Nikula > > Date: Mon Sep 3 16:25:12 2012 +0300 > > > > drm/i915: do not expose a dysfunctional backlight interface to userspace > > > > prevents backlight interface creation if the BIOS has not set the backlight > > PWM CTL registers that contain the max PWM value. It's apparently normal on > > those machines, so demote the message about it to debug level. > > > > Reported-by: Orion Poplawski > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330 > > Signed-off-by: Jani Nikula > > We may want to create an explicit bug/task to track the missing > initialisation as a reminder as well. I suspect we'll get them automatically when people complain about non-working backlights. Like they already do for non-working edp without the bios' help. Till that happens, I'm choosing blissfull ignorance ;-) > Reviewed-by: Chris Wilson Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch