From: Daniel Vetter Subject: Re: [PATCH] drm/i915: pass adjusted_mode to intel_choose_pipe_bpp_dither(), again Date: Fri, 2 Nov 2012 09:59:31 +0100 Message-ID: <20121102085931.GH5755@phenom.ffwll.local> References: <1351844395-9572-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 950819E826 for ; Fri, 2 Nov 2012 01:58:24 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id n13so1308483eaa.36 for ; Fri, 02 Nov 2012 01:58:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1351844395-9572-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 02, 2012 at 10:19:55AM +0200, Jani Nikula wrote: > Daniel's backmerge > > commit c2fb7916927e989ea424e61ce5fe617e54878827 > Merge: 29de6ce 6f0c058 > Author: Daniel Vetter > Date: Mon Oct 22 14:34:51 2012 +0200 > > Merge tag 'v3.7-rc2' into drm-intel-next-queued > > to solve conflicts blew up (either git or Daniel was trying to be too > clever for their own good; it's usually convenient to blame tools ;) and > caused the changes of > > commit 0c96c65b48fba3ffe9822a554cbc0cd610765cd5 > Author: Jani Nikula > Date: Wed Sep 26 18:43:10 2012 +0300 > > drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag > > in ironlake_crtc_mode_set() to be dropped. > > Fix the call in ironlake_crtc_mode_set() again, and while at it, also fix > the new, copy-pasted haswell_crtc_mode_set() to use adjusted_mode. > > Signed-off-by: Jani Nikula Applied, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 3c7fa92..4be95e8 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -5471,7 +5471,8 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc, > intel_crtc_update_cursor(crtc, true); > > /* determine panel color depth */ > - dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode); > + dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, > + adjusted_mode); > if (is_lvds && dev_priv->lvds_dither) > dither = true; > > @@ -5673,7 +5674,8 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, > intel_crtc_update_cursor(crtc, true); > > /* determine panel color depth */ > - dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode); > + dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, > + adjusted_mode); > if (is_lvds && dev_priv->lvds_dither) > dither = true; > > -- > 1.7.9.5 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch