From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 23 Nov 2012 07:54:29 +0100 Subject: [PATCH] ARM: Kirkwood: Add support LED of OpenBlocks A6 In-Reply-To: <1353629160-6002-1-git-send-email-iwamatsu@nigauri.org> References: <1353629160-6002-1-git-send-email-iwamatsu@nigauri.org> Message-ID: <20121123065429.GG9177@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Nov 23, 2012 at 09:06:00AM +0900, Nobuhiro Iwamatsu wrote: > OpenBlocks A6 has three leds via GPIO. This supports them. > And this fix typo about led, because hardware manual has typo. > > Signed-off-by: Nobuhiro Iwamatsu > --- > arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 19 +++++++++++++++++++ > arch/arm/mach-kirkwood/board-openblocks_a6.c | 4 ++-- > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts > index 37dc3a7..183df04 100644 > --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts > +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts > @@ -75,4 +75,23 @@ > }; > }; > }; > + > + gpio_leds { Hi Nobuhiro Thanks for the patch, looks good except for a minor point. The convention is to use gpio-leds, not gpio_leds. Thanks Andrew > + compatible = "gpio-leds"; > + > + led-red { > + label = "obsa6:red:stat"; > + gpios = <&gpio1 9 1>; > + }; > + > + led-green { > + label = "obsa6:green:stat"; > + gpios = <&gpio1 10 1>; > + }; > + > + led-yellow { > + label = "obsa6:yellow:stat"; > + gpios = <&gpio1 11 1>; > + }; > + }; > }; > diff --git a/arch/arm/mach-kirkwood/board-openblocks_a6.c b/arch/arm/mach-kirkwood/board-openblocks_a6.c > index e71f984..815fc64 100644 > --- a/arch/arm/mach-kirkwood/board-openblocks_a6.c > +++ b/arch/arm/mach-kirkwood/board-openblocks_a6.c > @@ -55,8 +55,8 @@ static unsigned int openblocks_a6_mpp_config[] __initdata = { > MPP38_GPIO, /* INIT */ > MPP39_GPIO, /* USB OC */ > MPP41_GPIO, /* LED: Red */ > - MPP42_GPIO, /* LED: Yellow */ > - MPP43_GPIO, /* LED: Green */ > + MPP42_GPIO, /* LED: Green */ > + MPP43_GPIO, /* LED: Yellow */ > 0, > }; > > -- > 1.7.10.4 >