From: Thierry Reding Subject: Re: [RFC 0/2] Add HDMI helpers Date: Fri, 23 Nov 2012 10:38:57 +0100 Message-ID: <20121123093857.GB21691@avionic-0098.adnet.avionic-design.de> References: <1353510113-4388-1-git-send-email-thierry.reding@avionic-design.de> <50AF40C6.9030306@vodafone.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0619697269==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTP id E5DCBE5C35 for ; Fri, 23 Nov 2012 01:39:21 -0800 (PST) In-Reply-To: <50AF40C6.9030306@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Christian =?utf-8?B?S8O2bmln?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0619697269== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 23, 2012 at 10:24:22AM +0100, Christian K=C3=B6nig wrote: > Hi Thierry, >=20 > On 21.11.2012 16:01, Thierry Reding wrote: > >This small series is very much work in progress, but I still wanted to > >get feedback in this early stage to gather requirements from the folks > >working on the display drivers that these helpers target. > > > >Patch 1 in the series adds a generic helper to pack a structure that > >describes an HDMI AVI infoframe into the binary format as specified in > >the HDMI specification. The resulting binary buffer should be easily > >programmable into the HDMI controller. > > > >Patch 2 provides a helper to fill an HDMI AVI infoframe with data from > >a struct drm_display_mode. > > > >This is all pretty rough right now, but I think some feedback would be > >good at this point, to see if the design is at all sensible. I should > >also mention that I haven't actually tested this on real hardware yet. > >Furthermore I have plans to add something similar for the other types > >of infoframes specified by HDMI once the direction becomes clearer. > In general I like the idea of storing the informations in a C struct > and only packing it into the binary form when needed. >=20 > I would rather like to see a complete implementation of all the > interesting HDMI packets, including the necessary > calculations/tables for audio timing recovery etc before it gets > committed upstream. I'm afraid I'm not very familiar with those packets. Also I haven't seen any actual users of audio timing recovery packets so far, so I'm not sure that adding support for them would be very useful. What I have added so far is support for audio and vendor-specific infoframes, since those have actual users. I also noticed that i915 implements SPD infoframes as well, so I can extract that code into the generic helpers as well. > Not sure about the separate configuration option. I'm not so much > into the config/build system of linux (I know that it is rather > complicated), but in general I would like to see that activated > automatically as soon as any driver starts using it (or at least the > driver depending on that option to be active). The configuration option isn't supposed to be user visible. Drivers that make use of this are supposed to select HDMI or DRM_HDMI to cause the generic code to be pulled in. > Also two notes about the code in itself: > 1. hdmi_avi_infoframe_pack: gets the size of the target buffer, but > unfortunately doesn't checks it. That should already be fixed in the latest code in my local working branch. > 2. Separate the CRC calculation, we probably need that more than once. I've also pulled that out into a separate function. I haven't made it a public function yet, but I don't think that'll be necessary either since it is used internally by the various infoframe packing functions. Thierry --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQr0QxAAoJEN0jrNd/PrOhoroP/3AqhkHThEi1LtaP0Z0kqQEk sSGrGEv4e8j5K71LqEFGZZJT3f8ZUa07gKLkaMNPoH1Vk1p8JyNkqahcw51d+i1d u2NsvHRt6aTeS34eM4OaeeWvTgPeBeRxaDSQm0uLhsa5fCXVyECXBJ125VTPAqAE zbR/I7Xct/HfNzFYVXQb3FZ00zNc9wPTY83BPC4qtMMC4KQE65PH817xvdYapJ10 +djjKylsR6xy19ynQVUkOM7aReq5tgU5U0oHoyvvADAHhmRUr1zDu61vwCbjBNZv jV1UBdg1OQuyPpsy4Q29makMp7LXZybweFezvK1NeCmdgJkOt5hRaPtbfbMO4H2k uMz5+0B+LYMrwTFlSeGni7Ry8cwzNh9zZmjMPBwsnmaDl4OQr1TY62lx8Od4XBGl NkYuCDwDxZyo2L03igT788IywsHM+1t2Ss13Ti6nGjb9+6KIQbn9POMMYi83UGic pU5svCFbHZPNFIq89zr8teU3XvfhTOVnp9eN5uiMqFZAVs7SX7DITm2qFu5/Theo rMbpm0fBBv9HXpaMy4Nlq0Wj2o/fLA/yZmKnTCA9zDe4Hz3C34PdNrSmwFmV0vZE W6Th0OUR8Wf0hdkkzC73XKGV5QTgsuQ90p9edfaq2SihyIKjsipu4Z8ElcjPbLB8 Dea97tHKvetxzXQq/Bwq =bYA9 -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb-- --===============0619697269== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0619697269==--