From: Andi Kleen Subject: Re: [PATCH] Custom interleaved allocation Date: Mon, 26 Nov 2012 21:21:06 +0100 Message-ID: <20121126202106.GO16230@one.firstfloor.org> References: <50AD2380.4010506@cslab.ece.ntua.gr> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <50AD2380.4010506@cslab.ece.ntua.gr> Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasileios Karakasis Cc: linux-numa@vger.kernel.org, =?utf-8?B?zpjOv860z4nPgc6uz4IgzpPOus6/z43Ovc+Ezr/Phc6yzrHPgg==?= > +{ > + int i; > + int nr_nodes = numa_num_configured_nodes(); > + int pagesize = numa_pagesize(); > + size_t *node_scores = calloc(nr_nodes, sizeof(*node_scores)); > + if (!node_scores) { > + perror("malloc"); > + exit(1); You cannot handle errors like this in the library. It's not fully clear to me what the interface of your proposed new function is. Can you send a spec of the new user interface in a manpage like format? Also it would be good to have some more information on the use case. My first reaction is that you can create any interleaving scheme you want anyways using the low level functions. -Andi