From: Wolfgang Denk Date: Thu, 20 Dec 2012 00:18:09 +0100 Subject: [U-Boot] [U-Boot, v2 2/6] cmd_sf: Add print messages on flash read/write commands In-Reply-To: <1355934463-24319-2-git-send-email-jagannadh.teki@gmail.com> References: <1355934463-24319-1-git-send-email-jagannadh.teki@gmail.com> <1355934463-24319-2-git-send-email-jagannadh.teki@gmail.com> Message-ID: <20121219231809.73D57202B12@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jagannadha Sutradharudu Teki, In message <1355934463-24319-2-git-send-email-jagannadh.teki@gmail.com> you wrote: > This patch adds a print messages while using 'sf read' and > 'sf write' commands to make sure that how many bytes read/written > from/into flash device. > > Signed-off-by: Jagannadha Sutradharudu Teki > --- > Changes in v2: > Move print messages from spi_flash.c into cmd_sf.c Please see previous comments, especially http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149663 http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149665 I object against adding more and more verbosity and code size, and in an inconsistent way. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de F u cn rd ths u cnt spl wrth a dm!