From: Wolfgang Denk Date: Fri, 21 Dec 2012 07:26:40 +0100 Subject: [U-Boot] [U-Boot, v2 1/6] cmd_sf: Add print messages on flash erase command In-Reply-To: References: <1355934463-24319-1-git-send-email-jagannadh.teki@gmail.com> <20121219231637.6535D202B12@gemini.denx.de> <20121220124925.A7E9C202B6F@gemini.denx.de> Message-ID: <20121221062640.43937200FAE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jagan Teki, In message you wrote: > > I thought it could be a good progress prints for sf read/write/erase > commands as we didn't have > these verbose prints before. > > Do you think these are useful/required messages?, please take my above concerns. Some people will like such verbocity, others will dislike it. Also, some people will dislike th memory footprint that comes with the added code. So in any case this should be configurable. But most of all: SF is just one storage device out of a much larger list. If we add such a feature, it should be done in common code and in a generic way that all similar devices can use as well. Please see again the other thread, and Simon's response. I think it makes sense to handle these things together, as a common set of patches. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The only person who always got his work done by Friday was Robinson Crusoe.