From: richardcochran@gmail.com (Richard Cochran) Date: Mon, 24 Dec 2012 07:46:59 +0100 Subject: [PATCH 2/2] cpts: fix a run time warn_on. In-Reply-To: <50D7101A.6020506@mvista.com> References: <50D7101A.6020506@mvista.com> Message-ID: <20121224064658.GA2390@netboy.at.omicron.at> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Dec 23, 2012 at 06:07:22PM +0400, Sergei Shtylyov wrote: > Hello. > > On 22-12-2012 23:41, Richard Cochran wrote: > > >This patch fixes a warning in clk_enable by calling clk_prepare first. > > >Signed-off-by: Richard Cochran > >--- > > drivers/net/ethernet/ti/cpts.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > >diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c > >index 5ab8fb4..3e32a31 100644 > >--- a/drivers/net/ethernet/ti/cpts.c > >+++ b/drivers/net/ethernet/ti/cpts.c > >@@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts) > > cpts->refclk = NULL; > > return; > > } > >+ clk_prepare(cpts->refclk); > > clk_enable(cpts->refclk); > > Maybe just call clk_prepare_enable() instead? Okay, will fix in v2. Thanks, Richard