From: Thierry Reding Subject: Re: [PATCH v3 9/9] drm: Remove duplicate drm_mode_cea_vic() Date: Mon, 14 Jan 2013 16:03:33 +0100 Message-ID: <20130114150333.GA24129@avionic-0098.adnet.avionic-design.de> References: <1358173828-31674-1-git-send-email-thierry.reding@avionic-design.de> <1358173828-31674-10-git-send-email-thierry.reding@avionic-design.de> <20130114145756.GG3867@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1016265075==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by gabe.freedesktop.org (Postfix) with ESMTP id 90144E5BFA for ; Mon, 14 Jan 2013 07:03:39 -0800 (PST) In-Reply-To: <20130114145756.GG3867@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1016265075== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 14, 2013 at 04:57:56PM +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > On Mon, Jan 14, 2013 at 03:30:28PM +0100, Thierry Reding wrote: > > The same function had already been merged with a different name. Remove > > the duplicate one but reuse some of its kerneldoc fragments for the > > existing implementation. >=20 > And I just used that function. Oh well ;) >=20 > Personally I would have kept the other function instead since it has a > more descriptive name, but I can't be bothered to care enough to > complain too much. drm_mode_cea_vic() was introduced later, so I preferred the older variant. > The patch could be moved to the beginning of the series, so it can be > merged w/o being blocked by the more invasive stuff. Well, assuming that > the more invasive stuff still needs discussing. I had it at the beginning of the series, then realized that I hadn't updated the i915 driver properly. So I cheated a bit and just moved the patch instead of updating i915 and then resolving the conflict in the subsequent i915 HDMI helper patch. =3D) If the series can't be merged as-is, I can work this in for the next version. Thierry --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ9B5FAAoJEN0jrNd/PrOhbDUQAIWOjFKeENkBFDFoiBBHUnyE O4LkHxw57lIzeuFuZJ+VDs0ir1kKbbcccfLDBusb3pL5XREIgWCnz/9hZI1Q93Uh OF6dUEWNqXqo0N/KE1NrHoqKwIaD1h4A5KUMlfnbqc4GaGIHgU1Jj0k5ajwkK8OF dvqbq0hV5yj2CvB+z9Sm798YILYCW027zvEihNkI0IKhaO8FmyECS+coVT3EG6nl 8uqSjndm7tid22K31MMQumIEHCrrjBHtqsuzFuF4ZF9v67bTA6W9IR+bH6yTQfZD 6wGmwNK4ITGb+IsCm//iAHTWNBwT34wNCZCW+v4uFGpOAQMYPY0melZH+HTjTgql Djek7as0/S9adU8CclFkfD+PhyJdIe2U36PRw59/eRT01q1e7tJi773D1OIDFoWL 0nHZjgJyeWrwh1gW8VbipWELHtxeWeb1/ajapzTSKD3x7y00Znpy6uuk7k5gmneQ FYEoqN5AnNBpUBu1E0fBlnpOflUqivlJyG6B3zvQmm8oPofYLH8JRptghjM6uNFy Db/0LG2E3ayP/ZIvqpGKRbciUeadsOWEspu2JKFeYK/SkHJmGH2KINf6vp0AoD90 4ShU/daXZFGKiC0YTDxf0E59Ys5cCr6/FGT0uOo7PYUIWd0U1pKG6Kyg3a56UoAU qfN+q2XXhI+/h2UgesU0 =txjz -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK-- --===============1016265075== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1016265075==--