From: Daniel Vetter Subject: Re: [PATCH] drm/i915/eDP: do not write power sequence registers for ghost eDP Date: Wed, 16 Jan 2013 10:29:33 +0100 Message-ID: <20130116092933.GA8347@phenom.ffwll.local> References: <1358326420-30642-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 6914AE6688 for ; Wed, 16 Jan 2013 01:27:57 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id c13so502147eek.14 for ; Wed, 16 Jan 2013 01:27:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <1358326420-30642-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 16, 2013 at 10:53:40AM +0200, Jani Nikula wrote: > Some machines detect an eDP port even if it's not really there, and eDP > initialization has a fail path for this. Typically such machines have an > LVDS display instead. A regression introduced in > > commit 82ed61fa1a4e08d5f9e86fb1b715b50ed678b6ac > Author: Daniel Vetter > Date: Sat Oct 20 20:57:41 2012 +0200 > > drm/i915: make edp panel power sequence setup more robust > > updated the power sequence registers PCH_PP_ON_DELAYS, PCH_PP_OFF_DELAYS, > and PCH_PP_DIVISOR also in the ghost eDP case, messing up the LVDS display. > > Split the power sequencer initialization into two, delaying the register > updates until after we know the eDP is real. > > Note: Keep the PP_CONTROL unlocking in the first part, even if it does not > update registers, per the commit message of the above mentioned commit. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52601 > Reported-and-tested-by: Ryan Coe > Signed-off-by: Jani Nikula Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch