From: Thierry Reding Subject: Re: [PATCH v3 3/9] video: Add generic HDMI infoframe helpers Date: Fri, 18 Jan 2013 09:56:36 +0100 Message-ID: <20130118085636.GA16395@avionic-0098.adnet.avionic-design.de> References: <1358173828-31674-1-git-send-email-thierry.reding@avionic-design.de> <1358173828-31674-4-git-send-email-thierry.reding@avionic-design.de> <20130116132714.GM3503@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0135823138==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.8]) by gabe.freedesktop.org (Postfix) with ESMTP id 86901E5C86 for ; Fri, 18 Jan 2013 00:56:39 -0800 (PST) In-Reply-To: <20130116132714.GM3503@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0135823138== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline --/04w6evG8XlLl3ft Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 16, 2013 at 03:27:14PM +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > On Mon, Jan 14, 2013 at 03:30:22PM +0100, Thierry Reding wrote: > > Add generic helpers to pack HDMI infoframes into binary buffers. [...] > > +/** > > + * hdmi_avi_infoframe_init() - initialize an HDMI AVI infoframe > > + * @frame: HDMI AVI infoframe > > + * > > + * Returns 0 on success or a negative error code on failure. > > + */ > > +int hdmi_avi_infoframe_init(struct hdmi_avi_infoframe *frame) > > +{ > > + if (!frame) > > + return -EINVAL; >=20 > There's quite a bit of error checking all around which seems a bit > pointless since this is all internal stuff. Any errors are bugs in > some driver code, so just letting the thing oops would be fine in my > opinion. Okay, I can remove some of the more obvious checks. Checking for space requirements might still be useful, so I'll leave that in. > > +ssize_t hdmi_spd_infoframe_pack(struct hdmi_spd_infoframe *frame, void= *buffer, > > + size_t size) [...] > > + for (i =3D 0; i < sizeof(frame->vendor); i++) > > + ptr[i] =3D frame->vendor[i]; > > + > > + for (i =3D 0; i < sizeof(frame->product); i++) > > + ptr[8 + i] =3D frame->product[i]; >=20 > memcpy() Done. > > +enum hdmi_spd_sdi { > > + HDMI_SPD_SDI_UNKNOWN, > > + HDMI_SPD_SDI_DSTB, > > + HDMI_SPD_SDI_DVDP, > > + HDMI_SPD_SDI_DVHS, > > + HDMI_SPD_SDI_HDDVR, > > + HDMI_SPD_SDI_DVC, > > + HDMI_SPD_SDI_DSC, > > + HDMI_SPD_SDI_VCD, > > + HDMI_SPD_SDI_GAME, > > + HDMI_SPD_SDI_PC, > > + HDMI_SPD_SDI_BD, > > + HDMI_SPD_SDI_SCD, >=20 > I believe SACD is a more correct name. Done. > HD DVD and PMP are missing from this list. I can't find any reference to those in CEA-861-D. HDMI 1.4 doesn't have them either. Can you provide any pointers? > > +enum hdmi_audio_coding_type { > > + HDMI_AUDIO_CODING_TYPE_STREAM, > > + HDMI_AUDIO_CODING_TYPE_IEC_60958, > > + HDMI_AUDIO_CODING_TYPE_AC3, > > + HDMI_AUDIO_CODING_TYPE_MPEG1, > > + HDMI_AUDIO_CODING_TYPE_MP3, > > + HDMI_AUDIO_CODING_TYPE_MPEG2, > > + HDMI_AUDIO_CODING_TYPE_AAC, > > + HDMI_AUDIO_CODING_TYPE_DTS, > > + HDMI_AUDIO_CODING_TYPE_ATRAC, > > + HDMI_AUDIO_CODING_TYPE_ONE_BIT_AUDIO, > > + HDMI_AUDIO_CODING_TYPE_DOLBY_DIGITAL_PLUS, > > + HDMI_AUDIO_CODING_TYPE_DTS_HD, > > + HDMI_AUDIO_CODING_TYPE_MAT_MLP, > > + HDMI_AUDIO_CODING_TYPE_DST, > > + HDMI_AUDIO_CODING_TYPE_WMPRO, >=20 > These don't always quite match the names in CEA-861-E. Wouldn't it > be better to use matching names? Are HD-DVD and PMP above listed in CEA-861-E? I'll need to find a copy of it and will go over this again and match the names to those in the document. > Also the audio coding extension type is missing. I assume this is also part of CEA-861-E as I can't find a reference in -D? Thanks for reviewing, Thierry --/04w6evG8XlLl3ft Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ+Q5EAAoJEN0jrNd/PrOhLRUP/312Re7o2d4kyD3LrGIyHkOe lfdZZcbeHpkxAIM41oMlAXP54Vedj7/aeWifvUocuCHA6NW7++6C/E3uB27GeTfK sQFh7nHq+0s3C+GQKZ3YU6RH2pVbIYZ0uAS1qRoR+WW3FEFcLjiowzOi/xW8rkAR W+Ufc9D8yqwya1OHnueTl4Wi3HFelzjr52GsSXsfxusCssGIE33V1B4Vc9KSN4so jOJ/FoHx/O3fIc+sYRFnQ7RIfe7fz122k9G6CKp6sTjcmkDdPenba5I+HAdv0pdx A/L7CIZG+r3x+ZHbXd8lI+nVKw6Ok0AAzVa/Xb0ejh3ARcZmIcP1s8qILxyDMdI+ ZaOFbcweAQ0ejVyEKktsIJy3Prhrc+WJidmFXffXPz/eCRE2pHU8Y+5b6uGVVaC2 JNzJkjVLTRzlkPgr81lYXfydax7RNpNrmyjCOC/d40ZvGq4KiGcHHehk8aTBvNja k+zQEJ7NkjLK0Pb3CAA973YjTtqIMDk+GIX4F/LqhFLTl2M8AcB1Q7aUCOVjZmat TuFLtHedQ2AQ2LFRHWtcTYK/mMjDPuHZjbGTn88HsjFiXCESj4GheuebD05pKn5c IJ0XLzJutSuK0KZYOaTXC6gy6EQoVtrdnxwrRn//EyO8pJptxpNMMtJQF8RdF6Hi b6ngEhtbGt8BKS1X8QLZ =dkGO -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft-- --===============0135823138== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0135823138==--