From: Chris Wilson Subject: Re: [PATCH 1/1] drm/i915: use gem_set_seqno() on hardware init Date: Tue, 22 Jan 2013 12:28:16 +0000 Message-ID: <20130122122816.GA2659@cantiga.alporthouse.com> References: <1358856737-20697-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C6C2EE5C4D for ; Tue, 22 Jan 2013 04:28:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <1358856737-20697-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 22, 2013 at 02:12:17PM +0200, Mika Kuoppala wrote: > When machine was rebooted or module was reloaded, > gem_hw_init() set last_seqno to be identical to next_seqno. > This lead to situation that waits for first ever request > always passed immediately regardless if it was actually > executed. > > Use gem_set_seqno() to be consistent how hw is > initialized on init, wrap and on resume. Nice catch, and you caught the only other side-effect I could spot of moving the seqno init, so Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre