From: Daniel Vetter Subject: Re: [PATCH 1/1] drm/i915: use gem_set_seqno() on hardware init Date: Tue, 22 Jan 2013 13:56:30 +0100 Message-ID: <20130122125630.GI31870@phenom.ffwll.local> References: <1358856737-20697-1-git-send-email-mika.kuoppala@intel.com> <20130122122816.GA2659@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 758C7E6048 for ; Tue, 22 Jan 2013 04:54:27 -0800 (PST) Received: by mail-wg0-f52.google.com with SMTP id 12so2076038wgh.19 for ; Tue, 22 Jan 2013 04:54:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130122122816.GA2659@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 22, 2013 at 12:28:16PM +0000, Chris Wilson wrote: > On Tue, Jan 22, 2013 at 02:12:17PM +0200, Mika Kuoppala wrote: > > When machine was rebooted or module was reloaded, > > gem_hw_init() set last_seqno to be identical to next_seqno. > > This lead to situation that waits for first ever request > > always passed immediately regardless if it was actually > > executed. > > > > Use gem_set_seqno() to be consistent how hw is > > initialized on init, wrap and on resume. > > Nice catch, and you caught the only other side-effect I could spot of > moving the seqno init, so > > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch