From: Ben Widawsky Subject: Re: [PATCH 2/7] drm/i915: use FPGA_DBG for the "unclaimed register" checks Date: Fri, 25 Jan 2013 17:03:09 -0800 Message-ID: <20130125170309.07165dd6@bwidawsk.net> References: <1359147462-3902-1-git-send-email-przanoni@gmail.com> <1359147462-3902-3-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id ADFCAE5FB7 for ; Fri, 25 Jan 2013 17:01:51 -0800 (PST) In-Reply-To: <1359147462-3902-3-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, 25 Jan 2013 18:57:37 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > We plan to treat GEN7_ERR_INT as an interrupt, so use this register > for the checks inside I915_WRITE. This way we can have the best of > both worlds: the error message with a register address and the > interrupt. > > V2: Split in 2 patches: one for the macro, one for changing the > register, as requested by Ben. > > Signed-off-by: Paulo Zanoni Assuming we can come to a consensus on patch 1, it's Reviewed-by: Ben Widawsky -- Ben Widawsky, Intel Open Source Technology Center